plusone/plusone-commons
1
1
Fork 1
Code Issues Pull Requests Actions Projects Releases 5 Activity

refactor!: 重构 PagingAndSortingQueryParams #69

Merged
zhouxy108 merged 1 commits from zhouxy108/plusone-commons:refactor/paging-and-sorting-query-params into dev 2025-10-12 01:33:19 +08:00
Conversation 0 Commits 1 Files Changed 2 +52 -65
zhouxy108 commented 2025-10-12 01:31:42 +08:00
Owner
Copy Link

将构建 PagingParams 的过程放在 PagingParamsBuilder 中。
当定义一个 PagingAndSortingQueryParams 的子类时，
该类应包含一个静态的 PagingParamsBuilder 单例对象，
使对 sortableProperties 的校验逻辑在类加载时执行。

原来的实现方式是将校验 sortableProperties 的逻辑放在
PagingAndSortingQueryParams 的构造方法中，
每创建一个对象就得执行一次，造成不必要的浪费。

将构建 `PagingParams` 的过程放在 `PagingParamsBuilder` 中。 当定义一个 `PagingAndSortingQueryParams` 的子类时， 该类应包含一个静态的 `PagingParamsBuilder` 单例对象， 使对 `sortableProperties` 的校验逻辑在类加载时执行。 原来的实现方式是将校验 `sortableProperties` 的逻辑放在 `PagingAndSortingQueryParams` 的构造方法中， 每创建一个对象就得执行一次，造成不必要的浪费。
zhouxy108 added 1 commit 2025-10-12 01:31:43 +08:00
refactor: 将构建过程放在 Builder 中以避免重复校验 d6681e133a
zhouxy108 requested review from Owners 2025-10-12 01:31:43 +08:00
zhouxy108 merged commit 8106126e79 into dev 2025-10-12 01:33:19 +08:00
zhouxy108 deleted branch refactor/paging-and-sorting-query-params 2025-10-12 01:33:19 +08:00
zhouxy108 removed review request for Owners 2025-10-12 01:42:15 +08:00
zhouxy108 added the
completed
 label 2025-10-12 01:42:31 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Indicates an unexpected problem or unintended behavior
completed
Indicates that an issue or discussion is completed
documentation
Indicates a need for improvements or additions to documentation
duplicate
Indicates similar issues, pull requests, or discussions
enhancement
Indicates new feature requests
help wanted
Indicates that a maintainer wants help on an issue or pull request
invalid
Indicates that an issue, pull request, or discussion is no longer relevant
question
Indicates that an issue, pull request, or discussion needs more information
wontfix
Indicates that work won't continue on an issue, pull request, or discussion
No Label
completed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
zhouxy108
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: plusone/plusone-commons#69
No description provided.
Delete Branch "zhouxy108/plusone-commons:refactor/paging-and-sorting-query-params"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?