From ee68cb4d003eb1c6883023a8fad7aa58efd0baeb Mon Sep 17 00:00:00 2001 From: ZhouXY108 Date: Wed, 27 May 2026 03:55:36 +0800 Subject: [PATCH] =?UTF-8?q?refactor:=20=E4=BC=98=E5=8C=96=E5=8F=98?= =?UTF-8?q?=E9=87=8F=E5=92=8C=E7=A7=81=E6=9C=89=E5=B5=8C=E5=A5=97=E7=B1=BB?= =?UTF-8?q?=E7=9A=84=E5=91=BD=E5=90=8D?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 将循环计数器变量从 'i' 重命名为更具描述性的 'itemIndex',提高代码可读性 - 将 JdbcExecutor 重命名为 TransactionJdbcExecutor 以更好地反映其事务处理功能 --- .../java/xyz/zhouxy/jdbc/JdbcOperationSupport.java | 12 ++++++------ .../java/xyz/zhouxy/jdbc/SimpleJdbcTemplate.java | 8 ++++---- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/main/java/xyz/zhouxy/jdbc/JdbcOperationSupport.java b/src/main/java/xyz/zhouxy/jdbc/JdbcOperationSupport.java index a2ccefc..a64624e 100644 --- a/src/main/java/xyz/zhouxy/jdbc/JdbcOperationSupport.java +++ b/src/main/java/xyz/zhouxy/jdbc/JdbcOperationSupport.java @@ -225,19 +225,19 @@ class JdbcOperationSupport { } final int paramsSize = params.size(); - int batchCount = (paramsSize + batchSize - 1) / batchSize; + final int batchCount = (paramsSize + batchSize - 1) / batchSize; final BatchUpdateResult result = new BatchUpdateResult(paramsSize, batchCount, batchSize); try (PreparedStatement stmt = conn.prepareStatement(sql)) { - int i = 0; + int itemIndex = 0; int batchIndex = 0; for (Object[] ps : params) { - i++; + itemIndex++; fillStatement(stmt, ps); stmt.addBatch(); - final int indexInBatch = i % batchSize; - if (indexInBatch == 0 || i >= paramsSize) { + final int indexInBatch = itemIndex % batchSize; + if (indexInBatch == 0 || itemIndex >= paramsSize) { try { int[] updateCounts = stmt.executeBatch(); result.recordSuccessBatch(batchIndex, updateCounts); @@ -248,7 +248,7 @@ class JdbcOperationSupport { updateCounts = ((BatchUpdateException) e).getUpdateCounts(); } else { - int n = (i >= paramsSize && indexInBatch != 0) ? indexInBatch : batchSize; + int n = (itemIndex >= paramsSize && indexInBatch != 0) ? indexInBatch : batchSize; updateCounts = new int[n]; Arrays.fill(updateCounts, UNKNOWN_COUNT); } diff --git a/src/main/java/xyz/zhouxy/jdbc/SimpleJdbcTemplate.java b/src/main/java/xyz/zhouxy/jdbc/SimpleJdbcTemplate.java index 6ec96de..d422dd3 100644 --- a/src/main/java/xyz/zhouxy/jdbc/SimpleJdbcTemplate.java +++ b/src/main/java/xyz/zhouxy/jdbc/SimpleJdbcTemplate.java @@ -204,7 +204,7 @@ public class SimpleJdbcTemplate implements JdbcOperations { final boolean autoCommit = conn.getAutoCommit(); try { conn.setAutoCommit(false); - operations.accept(new JdbcExecutor(conn)); + operations.accept(new TransactionJdbcExecutor(conn)); conn.commit(); } catch (Exception e) { @@ -240,7 +240,7 @@ public class SimpleJdbcTemplate implements JdbcOperations { final boolean autoCommit = conn.getAutoCommit(); try { conn.setAutoCommit(false); - if (operations.test(new JdbcExecutor(conn))) { + if (operations.test(new TransactionJdbcExecutor(conn))) { conn.commit(); } else { @@ -264,11 +264,11 @@ public class SimpleJdbcTemplate implements JdbcOperations { // #endregion - private static final class JdbcExecutor implements JdbcOperations { + private static final class TransactionJdbcExecutor implements JdbcOperations { private final Connection conn; - private JdbcExecutor(Connection conn) { + private TransactionJdbcExecutor(Connection conn) { this.conn = conn; }