zhouxy108/hutool
1
0
Fork 0
mirror of https://gitee.com/chinabugotech/hutool.git synced 2025-07-21 15:09:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(5.4.1): 修改code smell

Browse Source 
1.静态工具类构造器私有
2.优化过长方法名
This commit is contained in:
晴雨夜
2020-08-26 15:10:26 +08:00
parent 145b8cc6ca
commit e27eb9299b
2 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
hutool-core/src/main/java/cn/hutool/core/annotation/LeafCollection.java
View File

@@ -1,6 +1,10 @@
package cn.hutool.core.annotation;
import java.lang.annotation.*;
import java.lang.annotation.Documented;
import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.Target;
import java.lang.annotation.RetentionPolicy;
/**
* 叶容器-当对象存在树型结构,通过此注解标注属性告知存储位置

16
hutool-core/src/main/java/cn/hutool/core/lang/tree/TreeConvert.java
View File

@@ -10,7 +10,9 @@ import java.beans.IntrospectionException;
import java.beans.PropertyDescriptor;
import java.lang.reflect.Field;
import java.lang.reflect.InvocationTargetException;
import java.util.*;
import java.util.List;
import java.util.Collection;
import java.util.ArrayList;
/**
* 树结构转换工具
@@ -26,6 +28,13 @@ import java.util.*;
*/
public class TreeConvert {
/**
* 构造私有化，静态方法不需要暴露公共构造器
* 修复 <code>Add a private constructor to hide the implicit public one</code>
*/
private TreeConvert() {
}
/**
* 生成树结构
* 通过反射检测LeafCollection注解,转换为父子结构容器,子数据装入LeafCollection容器中
@@ -87,8 +96,11 @@ public class TreeConvert {
* @throws IntrospectionException e
* @throws InvocationTargetException e
* @throws IllegalAccessException e
*
* 2020-08-26 修复方法名过长
*/
private static <T> List<T> sort(T root, Collection<T> elements, LeafDecide<T> leafDecide, Class<?> clazz, Field leafField) throws IntrospectionException, InvocationTargetException, IllegalAccessException {
private static <T> List<T> sort(T root, Collection<T> elements, LeafDecide<T> leafDecide, Class<?> clazz, Field leafField)
throws IntrospectionException, InvocationTargetException, IllegalAccessException {
List<T> subMenu = null;
for (T element : elements) {
if (leafDecide.isLeaf(root, element)) {