From 4f17d18e0581941fabc6b4cf85267db00df4a642 Mon Sep 17 00:00:00 2001 From: Looly Date: Sun, 25 Jun 2023 15:58:34 +0800 Subject: [PATCH] fix code --- .../main/java/org/dromara/hutool/core/map/MapUtil.java | 10 +--------- .../java/org/dromara/hutool/core/map/MapUtilTest.java | 7 +++++++ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/hutool-core/src/main/java/org/dromara/hutool/core/map/MapUtil.java b/hutool-core/src/main/java/org/dromara/hutool/core/map/MapUtil.java index 29f9ddd9e..0246ad9e8 100644 --- a/hutool-core/src/main/java/org/dromara/hutool/core/map/MapUtil.java +++ b/hutool-core/src/main/java/org/dromara/hutool/core/map/MapUtil.java @@ -1013,15 +1013,7 @@ public class MapUtil extends MapGetUtil { return map; } - final Iterator> iter = map.entrySet().iterator(); - Entry entry; - while (iter.hasNext()) { - entry = iter.next(); - if (null == entry.getValue()) { - iter.remove(); - } - } - + map.entrySet().removeIf(entry -> null == entry.getValue()); return map; } diff --git a/hutool-core/src/test/java/org/dromara/hutool/core/map/MapUtilTest.java b/hutool-core/src/test/java/org/dromara/hutool/core/map/MapUtilTest.java index 1d91bf2e9..e58db6ffc 100644 --- a/hutool-core/src/test/java/org/dromara/hutool/core/map/MapUtilTest.java +++ b/hutool-core/src/test/java/org/dromara/hutool/core/map/MapUtilTest.java @@ -285,4 +285,11 @@ public class MapUtilTest { final Map map = MapUtil.renameKey(v1, "name", "newName"); Assertions.assertEquals("张三", map.get("newName")); } + + @Test + public void removeNullValueTest() { + final Dict v1 = Dict.of().set("id", 12).set("name", null).set("age", null); + final Map map = MapUtil.removeNullValue(v1); + Assertions.assertEquals(1, map.size()); + } }